Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20282 )

Change subject: KUDU-3498 Scanner keeps alive in periodically
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/20282/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20282/1//COMMIT_MSG@17
PS1, Line 17:  S
> nit: add a space before "So"
Done


http://gerrit.cloudera.org:8080/#/c/20282/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/20282/1/src/kudu/client/client-test.cc@2969
PS1, Line 2969: back
> nit: add period
Done


http://gerrit.cloudera.org:8080/#/c/20282/1/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/20282/1/src/kudu/client/client.h@2951
PS1, Line 2951: periodicly
> nit: periodically
Done


http://gerrit.cloudera.org:8080/#/c/20282/1/src/kudu/client/client.h@2952
PS1, Line 2952: Periodical
> nit: same as above, rename all instances of "periodicly" to "periodically"
Done



--
To view, visit http://gerrit.cloudera.org:8080/20282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81
Gerrit-Change-Number: 20282
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Comment-Date: Tue, 01 Aug 2023 02:02:55 +0000
Gerrit-HasComments: Yes

Reply via email to