Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 )
Change subject: KUDU-3498 Scanner keeps alive in periodically ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/client-test.cc@2987 PS3, Line 2987: 3 nit: Is it enough to sleep a bit over FLAGS_scanner_ttl_ms? http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/client.h@2952 PS3, Line 2952: KeepAliveInPeriodically nit: Rename it to KeepAlivePeriodically. Same as other places. http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/20282/3/src/kudu/client/scanner-internal.cc@104 PS3, Line 104: keep_alive_interval_ms nit: Is it worth making this a member variable with a default value of KuduScanner? Also, I noticed that the Java client has 'keepAlivePeriodMs' setting in KuduScannerIterator. And keepKuduScannerAlive is called in KuduScannerIterator#hasNext. Could we implement this in Cpp client the same way Java client does? -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 10 Aug 2023 06:45:35 +0000 Gerrit-HasComments: Yes
