Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 )
Change subject: KUDU-3498 Scanner keeps alive in periodically ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@14 PS2, Line 14: request. > request Done http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@14 PS2, Line 14: sent > sent Done http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@16 PS2, Line 16: adds support for keeping a scanner alive perio > adds support for keeping a scanner alive periodically Done http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@17 PS2, Line 17: ground. So, : it will nev > Why do we need to keep a scanner never expired? If a scan task is finished, What I want to say is the scanner will never be expired when it is in using, but will be expired when the scanner is destroyed. http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client-test.cc@2979 PS2, Line 2979: if (keep_alive_in_periodically) { > Is it always true? If so, could you also elaborate more on why the first ba OK. I will create a table with only one replica for test. http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client.h@2951 PS2, Line 2951: in periodical > periodically Done -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 09 Aug 2023 04:23:50 +0000 Gerrit-HasComments: Yes
