Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 )
Change subject: KUDU-3498 Scanner keeps alive in periodically ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@14 PS2, Line 14: send sent http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@14 PS2, Line 14: requests request http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@16 PS2, Line 16: supports to keep scanner alive in periodically adds support for keeping a scanner alive periodically http://gerrit.cloudera.org:8080/#/c/20282/2//COMMIT_MSG@17 PS2, Line 17: So, it will never : be expired. Why do we need to keep a scanner never expired? If a scan task is finished, it should be removed since a scanner keeps resources on the server. http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client-test.cc@2979 PS2, Line 2979: ASSERT_EQ(batch.NumRows(), 9); Is it always true? If so, could you also elaborate more on why the first batch always contains exactly 9 rows? http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/20282/2/src/kudu/client/client.h@2951 PS2, Line 2951: in periodicly periodically -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 09 Aug 2023 03:08:20 +0000 Gerrit-HasComments: Yes
