Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20292 )
Change subject: logging.cc: Call GetLoggingDirectories before first write ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20292/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20292/2//COMMIT_MSG@1 PS2, Line 1: Parent: 8eff8f90 ([doc] remove the supportng of el6) What was the manifestation before, which led you to make this patch, could you please elaborate? Could that be baked into a test? http://gerrit.cloudera.org:8080/#/c/20292/2//COMMIT_MSG@7 PS2, Line 7: logging.cc: nit: [logging] like: git log --grep="\[logging" -- To view, visit http://gerrit.cloudera.org:8080/20292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0 Gerrit-Change-Number: 20292 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 01 Aug 2023 12:54:05 +0000 Gerrit-HasComments: Yes
