Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20292 )
Change subject: [logging] Call GetLoggingDirectories before first write ...................................................................... Patch Set 3: (5 comments) There isn't any specific reason to create new changelist. It accidentally got a new change-id. http://gerrit.cloudera.org:8080/#/c/20292/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20292/2//COMMIT_MSG@1 PS2, Line 1: Parent: 8eff8f90 ([doc] remove the supportng of el6) > What was the manifestation before, which led you to make this patch, could Done http://gerrit.cloudera.org:8080/#/c/20292/2//COMMIT_MSG@7 PS2, Line 7: [logging] C > nit: [logging] Done http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/integration-tests/log-rolling-itest.cc File src/kudu/integration-tests/log-rolling-itest.cc: http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/integration-tests/log-rolling-itest.cc@56 PS3, Line 56: > nit: wrong indent, should be 2 spaces per current code style Done http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/integration-tests/log-rolling-itest.cc@60 PS3, Line 60: > nit: wrong indent Done http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/util/logging.cc File src/kudu/util/logging.cc: http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/util/logging.cc@251 PS3, Line 251: GetLoggingDirectories initializes global state in a non thread-safe manner > Could you also add a bit more of context here about when GetLoggingDirector Done -- To view, visit http://gerrit.cloudera.org:8080/20292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0 Gerrit-Change-Number: 20292 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Mon, 07 Aug 2023 15:13:05 +0000 Gerrit-HasComments: Yes
