Hello Marton Greber, Alexey Serbin, Kudu Jenkins, Wang Xixu,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20292
to look at the new patch set (#4).
Change subject: [logging] Call GetLoggingDirectories before first write
......................................................................
[logging] Call GetLoggingDirectories before first write
Glog has a function called GetLoggingDirectories, which is explicitly not
thread-safe[1]. The comment promises it's not an issue since it is called
in InitGoogle, but it's not true right now, so it's called after
InitGoogleLogging as a workaround.
The workaround simply makes sure that GetLoggingDirectories is executed
in a single thread so logging_directories_list will be initialized in a
thread-safe location.
log-rolling-itest.TestLogCleanupOnStartup failed occasionally because of
the error, so it was made more robust (more attempt and check both INFO
and WARNING log files) to make sure log files are created and with the
fix it passes every time.
1:
https://github.com/google/glog/blob/674283420118bb919f83ceb3d9dee31ef43ff3aa/src/logging.cc#L2325
Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0
---
M src/kudu/integration-tests/log-rolling-itest.cc
M src/kudu/util/logging.cc
2 files changed, 30 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/20292/4
--
To view, visit http://gerrit.cloudera.org:8080/20292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0
Gerrit-Change-Number: 20292
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Ádám Bakai <[email protected]>
