Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20292 )
Change subject: [logging] Call GetLoggingDirectories before first write ...................................................................... Patch Set 3: Code-Review+1 (7 comments) Thank you for the fix. http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/integration-tests/log-rolling-itest.cc File src/kudu/integration-tests/log-rolling-itest.cc: http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/integration-tests/log-rolling-itest.cc@56 PS3, Line 56: log_dir,"INFO" nit: missing space to separating the arguments http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/integration-tests/log-rolling-itest.cc@56 PS3, Line 56: nit: wrong indent, should be 2 spaces per current code style http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/integration-tests/log-rolling-itest.cc@60 PS3, Line 60: nit: wrong indent http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/integration-tests/log-rolling-itest.cc@60 PS3, Line 60: log_dir,"WARNING" nit: missing space to separating the arguments http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/integration-tests/log-rolling-itest.cc@64 PS3, Line 64: TEST_F(LogRollingITest, TestLogCleanupOnStartup) { Since you are updating the code in this test anyways, please also add SKIP_IF_SLOW_NOT_ALLOWED() in the very beginning of the test (at least for non-sanitizer case). This test scenario is running for more than 10 seconds even prior to the changes you've made here, and any test running longer than 3 seconds is considered slow in Kudu. http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/util/logging.cc File src/kudu/util/logging.cc: http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/util/logging.cc@251 PS3, Line 251: GetLoggingDirectories initializes global state in a non thread-safe manner Could you also add a bit more of context here about when GetLoggingDirectories() is called, so it would be clearer to the reader that it might be a race? Thank you! http://gerrit.cloudera.org:8080/#/c/20292/3/src/kudu/util/logging.cc@299 PS3, Line 299: nit: remove the extra space? -- To view, visit http://gerrit.cloudera.org:8080/20292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9acaaf822efee538b7eb887ddbe964198fdb3a0 Gerrit-Change-Number: 20292 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 03 Aug 2023 17:19:26 +0000 Gerrit-HasComments: Yes
