Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20270 )
Change subject: [client] Avoid impala crash by returning error if invalid tablet id found ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20270/3//COMMIT_MSG Commit Message: PS3: > If you are talking about adding a unit test for this change, I don't think Yeah, so please add a test that would fail without this patch (e.g., something like death test, etc.), and with this patch it simply returns a proper error status. That is necessary at least to make sure the newly updated code works as expected under particular conditions, and also to catch regressions if the code around changes. You can always have a scenario where you have multiple instances of a C++ client. I don't think the fact that Impala uses Java client for DDL is crucial -- if a table's partitioning is updated by some other instance of the C++ client, the bug will manifest itself, right? -- To view, visit http://gerrit.cloudera.org:8080/20270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia09cf6fb1b1d10f1ad13a62b5c863bcd1e3ab26a Gerrit-Change-Number: 20270 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Aug 2023 16:37:49 +0000 Gerrit-HasComments: Yes
