Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20270 )
Change subject: [client] Avoid impala crash by returning error if invalid tablet id found ...................................................................... Patch Set 3: (1 comment) Thank you for comments/suggestions. http://gerrit.cloudera.org:8080/#/c/20270/3//COMMIT_MSG Commit Message: PS3: > Yeah, so please add a test that would fail without this patch (e.g., someth It should manifest as the client objects would be different and each client object should have its own metacache object copy. I have tested the fix with the actual repro steps of imapala-shell using kudu c++ client as well java client to verify the expected behaviour of impalad upon receiving the error. However, I can look into adding a test, as you suggested, with two instances of c++ client. I would like to take that up in a separate follow-up change. -- To view, visit http://gerrit.cloudera.org:8080/20270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia09cf6fb1b1d10f1ad13a62b5c863bcd1e3ab26a Gerrit-Change-Number: 20270 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Aug 2023 14:18:14 +0000 Gerrit-HasComments: Yes
