Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20270 )
Change subject: [client] Avoid impala crash by returning error if invalid tablet id found ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20270/3//COMMIT_MSG Commit Message: PS3: > It should manifest as the client objects would be different and each client We need to have an automated test due to the reasons I described in my prior comment. Impala will need to add an automated test as well. However, Impala has its own release cycle, and if a regression appears in the Kudu client library, it's better to catch it as soon as possible. So, a test should be in the Kudu repo, and that test might check and explore much more than Impala's test could ever do. Why not to add the test right in this patch? Isn't it a trivial one? -- To view, visit http://gerrit.cloudera.org:8080/20270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia09cf6fb1b1d10f1ad13a62b5c863bcd1e3ab26a Gerrit-Change-Number: 20270 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Aug 2023 17:50:13 +0000 Gerrit-HasComments: Yes
