Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22058 )
Change subject: WIP [docs] add information on nullable array data block ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/22058/1/docs/design-docs/cfile.md File docs/design-docs/cfile.md: http://gerrit.cloudera.org:8080/#/c/22058/1/docs/design-docs/cfile.md@151 PS1, Line 151: array start indices When storing the starting indices of each array, we might end up storing large values if the number of arrays in the block is big. Instead how about storing the length of each array(which would introduce some latency)? If the length of the 100th array is 3 elements, Current way would store it as [...100,102...] Instead we could store it as [<99th array length>,3,<101th array length>] There are definitely pros and cons of each way but not sure if that is already thought through before arriving here. If so I'm curious to know the thoughts. http://gerrit.cloudera.org:8080/#/c/22058/1/docs/design-docs/cfile.md@180 PS1, Line 180: null arrays nit: "array null" -- To view, visit http://gerrit.cloudera.org:8080/22058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8972b3791d155e102240c80012e2b87192914cd1 Gerrit-Change-Number: 22058 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Nov 2024 20:05:14 +0000 Gerrit-HasComments: Yes
