Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22314 )
Change subject: KUDU-3563 Output tablet-level metrics in Prometheus ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc File src/kudu/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc@145 PS3, Line 145: tablet_metric_entity_ style nit: remove trailing '_'? http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc@149 PS3, Line 149: auto tablet_metric_entity_2 = : METRIC_ENTITY_tablet.Instantiate(®istry_, "11111111111111111111111111111111"); : scoped_refptr<Counter> counter2 = METRIC_tablet_test_counter.Instantiate(tablet_metric_entity_2); style nit: consider using same style for naming variables -- { 'tablet_metric_entity_2', 'counter_2'} or { 'tablet_metric_entity2', 'counter2' }, but don't mix the styles http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc@154 PS3, Line 154: nit: remove two extra empty lines? http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc@169 PS3, Line 169: nit: remove this extra empty line? http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc@428 PS3, Line 428: kTabletPrefix style nit: non-static/non-constexpr constant variables should be named as regular variables http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc@446 PS3, Line 446: return Status::NotSupported( Did you try running this against the '/prometheus_metrics' HTTP endpoint of kudu-master where at least one table is present? I think it's necessary to fix the issue of how this code handles entities of 'table' type and add a test to catch future regressions. It might be something similar to what we have currently in MasterTest.TestMasterContentTypeHeaders, but it should run against a cluster with some tables and maybe even a few rows of data. http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc@447 PS3, Line 447: server-level Once the code at lines 411-417 has been removed from the 'Base' version, this might be other than server-level entity's context -- To view, visit http://gerrit.cloudera.org:8080/22314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af Gerrit-Change-Number: 22314 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2025 20:21:05 +0000 Gerrit-HasComments: Yes
