Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/22314 )
Change subject: KUDU-3563 Output tablet-level metrics in Prometheus ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc File src/kudu/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc@145 PS3, Line 145: tablet_metric_entity_ > style nit: remove trailing '_'? Done http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc@149 PS3, Line 149: auto tablet_metric_entity_2 = : METRIC_ENTITY_tablet.Instantiate(®istry_, "11111111111111111111111111111111"); : scoped_refptr<Counter> counter2 = METRIC_tablet_test_counter.Instantiate(tablet_metric_entity_2); > style nit: consider using same style for naming variables -- { 'tablet_metr Done http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc@154 PS3, Line 154: > nit: remove two extra empty lines? Done http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics-test.cc@169 PS3, Line 169: > nit: remove this extra empty line? Done http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc@446 PS3, Line 446: return Status::NotSupported( > Did you try running this against the '/prometheus_metrics' HTTP endpoint of 1. I refactored the code so that tables would work as well. Tested in metrics-test. But at this point there is no table-level metric, so it would not be used in production. 2. I checked MasterTest.TestMasterContentTypeHeader, I don't see its relevance. But I see some tests where metrics website is used on a real cluster, like MasterTest::ServerAttributes and these tests always use "metrics" endpoint and not the prometheus endpoint. I agree that it would make sense to create a test like that but in my opinion it is out of the scope, if the scope is just make tablet metrics visible in prometheus. http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc@447 PS3, Line 447: server-level > Once the code at lines 411-417 has been removed from the Refactored that part of the code. -- To view, visit http://gerrit.cloudera.org:8080/22314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af Gerrit-Change-Number: 22314 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 13:50:29 +0000 Gerrit-HasComments: Yes
