Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22314 )

Change subject: KUDU-3563 Output tablet-level metrics in Prometheus
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc
File src/kudu/util/metrics.cc:

http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc@446
PS3, Line 446:   return Status::NotSupported(
> You are correct. There are table level metrics, I missed them somehow. I ch
I'd also check out the WARNING log of kudu-master after fetching the metrics in 
Prometheus format from it -- at least to make sure there isn't any other 
surprises in the new code.

Thanks a lot!



--
To view, visit http://gerrit.cloudera.org:8080/22314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Gerrit-Change-Number: 22314
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Ádám Bakai <[email protected]>
Gerrit-Comment-Date: Sat, 25 Jan 2025 05:33:22 +0000
Gerrit-HasComments: Yes

Reply via email to