Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/22314 )
Change subject: KUDU-3563 Output tablet-level metrics in Prometheus ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/22314/3/src/kudu/util/metrics.cc@446 PS3, Line 446: > > But at this point there is no table-level metric, so it would not be used You are correct. There are table level metrics, I missed them somehow. I checked, there are metrics for tables(they are identified by id, not table_name): # HELP kudu_table_34c04d66992842a6863ec8ff2d30be1f_merged_entities_count_of_table Count of entities merged together when entities are merged by common attribute value. # TYPE kudu_table_34c04d66992842a6863ec8ff2d30be1f_merged_entities_count_of_table gauge kudu_table_34c04d66992842a6863ec8ff2d30be1f_merged_entities_count_of_table{unit_type="entries"} 1 # HELP kudu_table_34c04d66992842a6863ec8ff2d30be1f_schema_version The table's schema version. # TYPE kudu_table_34c04d66992842a6863ec8ff2d30be1f_schema_version gauge kudu_table_34c04d66992842a6863ec8ff2d30be1f_schema_version{unit_type="units"} 1 # HELP kudu_table_34c04d66992842a6863ec8ff2d30be1f_column_count The column count in the table's latest schema. # TYPE kudu_table_34c04d66992842a6863ec8ff2d30be1f_column_count gauge kudu_table_34c04d66992842a6863ec8ff2d30be1f_column_count{unit_type="units"} 4 # HELP kudu_table_34c04d66992842a6863ec8ff2d30be1f_on_disk_size Pre-replication aggregated disk space used by all tablets in this table, including metadata. # TYPE kudu_table_34c04d66992842a6863ec8ff2d30be1f_on_disk_size gauge kudu_table_34c04d66992842a6863ec8ff2d30be1f_on_disk_size{unit_type="bytes"} 84211311 # HELP kudu_table_34c04d66992842a6863ec8ff2d30be1f_live_row_count Pre-replication aggregated number of live rows in this table. Only accurate if all tablets in the table support live row counting. # TYPE kudu_table_34c04d66992842a6863ec8ff2d30be1f_live_row_count gauge kudu_table_34c04d66992842a6863ec8ff2d30be1f_live_row_count{unit_type="rows"} 1000 # HELP kudu_table_287c3b836ab64cb3914b2fb052e26862_merged_entities_count_of_table Count of entities merged together when entities are merged by common attribute value. # TYPE kudu_table_287c3b836ab64cb3914b2fb052e26862_merged_entities_count_of_table gauge kudu_table_287c3b836ab64cb3914b2fb052e26862_merged_entities_count_of_table{unit_type="entries"} 1 # HELP kudu_table_287c3b836ab64cb3914b2fb052e26862_schema_version The table's schema version. # TYPE kudu_table_287c3b836ab64cb3914b2fb052e26862_schema_version gauge kudu_table_287c3b836ab64cb3914b2fb052e26862_schema_version{unit_type="units"} 1 # HELP kudu_table_287c3b836ab64cb3914b2fb052e26862_column_count The column count in the table's latest schema. # TYPE kudu_table_287c3b836ab64cb3914b2fb052e26862_column_count gauge kudu_table_287c3b836ab64cb3914b2fb052e26862_column_count{unit_type="units"} 4 # HELP kudu_table_287c3b836ab64cb3914b2fb052e26862_on_disk_size Pre-replication aggregated disk space used by all tablets in this table, including metadata. # TYPE kudu_table_287c3b836ab64cb3914b2fb052e26862_on_disk_size gauge kudu_table_287c3b836ab64cb3914b2fb052e26862_on_disk_size{unit_type="bytes"} 84211271 # HELP kudu_table_287c3b836ab64cb3914b2fb052e26862_live_row_count Pre-replication aggregated number of live rows in this table. Only accurate if all tablets in the table support live row counting. # TYPE kudu_table_287c3b836ab64cb3914b2fb052e26862_live_row_count gauge kudu_table_287c3b836ab64cb3914b2fb052e26862_live_row_count{unit_type="rows"} 1000 I will work on additional tests according to yout suggestions. -- To view, visit http://gerrit.cloudera.org:8080/22314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af Gerrit-Change-Number: 22314 Gerrit-PatchSet: 5 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:01:45 +0000 Gerrit-HasComments: Yes
