Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22984 )
Change subject: KUDU-1457 [1/n] add IPv6 support to net utils ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/22984/10/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/22984/10/src/kudu/util/net/net_util.cc@205 PS10, Line 205: host_ nit: Here and below maybe use a helper function to assign the host and port to reduce duplication http://gerrit.cloudera.org:8080/#/c/22984/10/src/kudu/util/net/net_util.cc@506 PS10, Line 506: p.second Probably check p.second is numeric value and nothing else right after line 497? -- To view, visit http://gerrit.cloudera.org:8080/22984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c773ffb2ff44b9cd765b546d6724ec5543586f Gerrit-Change-Number: 22984 Gerrit-PatchSet: 10 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 04 Aug 2025 00:15:24 +0000 Gerrit-HasComments: Yes
