Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22984 )
Change subject: KUDU-1457 [1/n] add IPv6 support to net utils ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/22984/10/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/22984/10/src/kudu/util/net/net_util.cc@450 PS10, Line 450: IN6_IS_ADDR_LOOPBACK In macOS(14.7) I see the below issue when compiling: 0: error: member reference base type 'uint128_t' (aka 'unsigned __int128') is not a structure or union return IN6_IS_ADDR_LOOPBACK(&addr); The issue arises because a uint128_t (i.e., unsigned __int128) is being passed to the IN6_IS_ADDR_LOOPBACK() macro, which expects a pointer to a struct in6_addr whihc seems to be macOS specific. Probably do something like: struct in6_addr ip6; static_assert(sizeof(ip6) == sizeof(addr), "IPv6 address size mismatch"); memcpy(&ip6, &addr, sizeof(ip6)); return IN6_IS_ADDR_LOOPBACK(&ip6); -- To view, visit http://gerrit.cloudera.org:8080/22984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c773ffb2ff44b9cd765b546d6724ec5543586f Gerrit-Change-Number: 22984 Gerrit-PatchSet: 10 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 04 Aug 2025 01:19:28 +0000 Gerrit-HasComments: Yes
