Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22984 )
Change subject: KUDU-1457 [1/n] add IPv6 support to net utils ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/22984/10/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/22984/10/src/kudu/util/net/net_util.cc@205 PS10, Line 205: host_ > nit: Here and below maybe use a helper function to assign the host and port Done http://gerrit.cloudera.org:8080/#/c/22984/10/src/kudu/util/net/net_util.cc@450 PS10, Line 450: IN6_IS_ADDR_LOOPBACK > In macOS(14.7) I see the below issue when compiling: Interesting! in6_addr is a union of 128 bits (a 128 bit stream in network order, if you will) in three different combinations. And this is same for both linux and macOS. It seems there is some leniency in Linux which is not tolerated on macOS. Marton raised a similar concern from the type correctness point of view. I guess there is no way to avoid memcpy here. Is everything else compiling successfully for you on macOS? I am not able to verify on macOS at my end due to some openssl config issue. http://gerrit.cloudera.org:8080/#/c/22984/10/src/kudu/util/net/net_util.cc@506 PS10, Line 506: p.second > Probably check p.second is numeric value and nothing else right after line Anyway, bit limit has to be checked again. -- To view, visit http://gerrit.cloudera.org:8080/22984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c773ffb2ff44b9cd765b546d6724ec5543586f Gerrit-Change-Number: 22984 Gerrit-PatchSet: 10 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 04 Aug 2025 14:00:54 +0000 Gerrit-HasComments: Yes
