Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23481 )
Change subject: KUDU-1261 [Java] Implement serdes of Array Type column ...................................................................... Patch Set 12: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/23481/11/java/gradle/quality.gradle File java/gradle/quality.gradle: http://gerrit.cloudera.org:8080/#/c/23481/11/java/gradle/quality.gradle@36 PS11, Line 36: > No, the difference comes from the sourceSets { java { } } block in the kudu This make sense, thanks. http://gerrit.cloudera.org:8080/#/c/23481/11/java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java File java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java: http://gerrit.cloudera.org:8080/#/c/23481/11/java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java@55 PS11, Line 55: > Thanks Zoltan. Yes, that is the standard followed in Kudu Java codebase. Whoops, I conflated it with C++ style code here :) In the Java style, those should be prefixed with get/set, indeed. And the Kudu Java client code follows the common convention as well. http://gerrit.cloudera.org:8080/#/c/23481/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestArraySerdes.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestArraySerdes.java: http://gerrit.cloudera.org:8080/#/c/23481/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestArraySerdes.java@308 PS12, Line 308: empty nit: this is null, not empty array, isn't it? Or maybe you meant something else? -- To view, visit http://gerrit.cloudera.org:8080/23481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1ad9f65fe94c8662ed0e0834ce849e078fc72d2 Gerrit-Change-Number: 23481 Gerrit-PatchSet: 12 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 20:28:04 +0000 Gerrit-HasComments: Yes
