Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23481 )
Change subject: KUDU-1261 [Java] Implement serdes of Array Type column ...................................................................... Patch Set 2: (2 comments) Quick feedback response: I think it makes sense to brush up the gradle-related parts to be uniform across the project. http://gerrit.cloudera.org:8080/#/c/23481/2/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/23481/2/java/kudu-client/build.gradle@43 PS2, Line 43: "com.google.flatbuffers:flatbuffers-java:25.2.10" Is it possible to use the same approach as for other Java dependencies: register the package's nickname and version in gradle/dependencies.gradle, and use the nickname here? http://gerrit.cloudera.org:8080/#/c/23481/2/java/kudu-client/build.gradle@62 PS2, Line 62: // Build FlatBuffers : def fbsDir = file("$rootDir/../src/kudu/common/serdes/") : def flatcOutputDir = file("$buildDir/generated/flatbuffers") : : def flatcCandidates = fileTree(dir: "${projectDir}/../../thirdparty/build", : includes: ["flatbuffers-*/flatc*", "flatbuffers-*/flatc.exe"]).files : if (flatcCandidates.size() != 1) { : throw new GradleException("Expected exactly 1 flatc binary, found: ${flatcCandidates}") : } : def flatcExe = flatcCandidates.first().absolutePath : : tasks.register("generateFlatBuffers", Exec) { : inputs.files fileTree(dir: fbsDir, include: '**/*.fbs') : outputs.dir flatcOutputDir : : doFirst { : def fbsFiles = fileTree(dir: fbsDir, include: '**/*.fbs').files : if (fbsFiles.isEmpty()) { : println "No .fbs files found in ${fbsDir}. Skipping FlatBuffers generation." : enabled = false : return : } : flatcOutputDir.mkdirs() : commandLine = [flatcExe, '--java', '--java-package-prefix', 'org.apache.', : '-o', flatcOutputDir.absolutePath] + fbsFiles.collect { it.path } : } : } : : sourceSets { : main { : java { : srcDir flatcOutputDir : } : } : } : : compileJava.dependsOn(tasks.named("generateFlatBuffers")) Move this into flatbuffers.gradle, similar to protobuf.gradle? -- To view, visit http://gerrit.cloudera.org:8080/23481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1ad9f65fe94c8662ed0e0834ce849e078fc72d2 Gerrit-Change-Number: 23481 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 01 Oct 2025 21:38:27 +0000 Gerrit-HasComments: Yes
