Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23481 )
Change subject: KUDU-1261 [Java] Implement serdes of Array Type column ...................................................................... Patch Set 13: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/23481/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestArraySerdes.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestArraySerdes.java: http://gerrit.cloudera.org:8080/#/c/23481/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestArraySerdes.java@308 PS12, Line 308: > The value returned here is empty array -> int[0] and not NULL. OK, this is a bit convoluted, so a small summary comment in the code would be helpful, I guess. Also, does it make sense to assert or res.getValidity() properties here as well, i.e. nullness, length (if it's not null)? -- To view, visit http://gerrit.cloudera.org:8080/23481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1ad9f65fe94c8662ed0e0834ce849e078fc72d2 Gerrit-Change-Number: 23481 Gerrit-PatchSet: 13 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 23:19:46 +0000 Gerrit-HasComments: Yes
