Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23481 )
Change subject: KUDU-1261 [Java] Implement serdes of Array Type column ...................................................................... Patch Set 11: Code-Review+1 (1 comment) overall looks good to me with Alexey's comments taken care of http://gerrit.cloudera.org:8080/#/c/23481/11/java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java File java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java: http://gerrit.cloudera.org:8080/#/c/23481/11/java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java@55 PS11, Line 55: getValues > style nit: use field accessor-style method name instead, i.e. values()? I don't necessarily agree, getters and setters (getX, setX) are pretty much standard in Java -- To view, visit http://gerrit.cloudera.org:8080/23481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1ad9f65fe94c8662ed0e0834ce849e078fc72d2 Gerrit-Change-Number: 23481 Gerrit-PatchSet: 11 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 08:20:00 +0000 Gerrit-HasComments: Yes
