Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24176 )

Change subject: WIP [rpc] in-bulk memory recycling for 
Connection::ProcessOutboundTransfers()
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24176/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24176/2//COMMIT_MSG@45
PS2, Line 45:   #11 kudu::rpc::InboundCall::~InboundCall (...)
Trying to understand this callstack - what bugs me is that the change is around 
sending data while the callstacks has the destructor in InboundCall. Does this 
happen when an incoming RPC is replied, so when the senders have sent the reply 
back to the receiver, leading to deleting both the request and response?

Adding the missing 5 calls may make this clearer.



--
To view, visit http://gerrit.cloudera.org:8080/24176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf7ab105a851ef4d583efc2d1b33d57607810df0
Gerrit-Change-Number: 24176
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Thu, 09 Apr 2026 06:41:21 +0000
Gerrit-HasComments: Yes

Reply via email to