Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24176 )
Change subject: WIP [rpc] in-bulk memory recycling for Connection::ProcessOutboundTransfers() ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24176/2/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: http://gerrit.cloudera.org:8080/#/c/24176/2/src/kudu/rpc/connection.cc@699 PS2, Line 699: outbound_transfers_.pop_front(); > Right: reading https://theboostcpplibraries.com/boost.intrusive should help I meant: recycled_transfers.push_back(transfer); and auto* transfer = recycled_transfers.front(); recycled_transfers.pop_front(); delete transfer; I'm not quite sure what the decltype to turn that into a pointer would look like. But I'll defer to you, I'm not really familiar with boost.intrusive. -- To view, visit http://gerrit.cloudera.org:8080/24176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf7ab105a851ef4d583efc2d1b33d57607810df0 Gerrit-Change-Number: 24176 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 09 Apr 2026 21:16:54 +0000 Gerrit-HasComments: Yes
