Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/24176 )
Change subject: WIP [rpc] in-bulk memory recycling for Connection::ProcessOutboundTransfers() ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24176/1/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: http://gerrit.cloudera.org:8080/#/c/24176/1/src/kudu/rpc/connection.cc@455 PS1, Line 455: auto* call_from_map = EraseKeyReturnValuePtr( This might get unused warnings in prod builds http://gerrit.cloudera.org:8080/#/c/24176/1/src/kudu/rpc/connection.cc@508 PS1, Line 508: auto t(OutboundTransfer::CreateForCallResponse(std::move(tmp_slices), std::move(cb))); This will leak tmp_slices and cb if CreateForCallResponseThrows out of memory http://gerrit.cloudera.org:8080/#/c/24176/1/src/kudu/rpc/connection.cc@668 PS1, Line 668: boost::intrusive::list<OutboundTransfer> recycled_transfers; // NOLINT(*) Let's be cautious about adding memory traffic from list<> operations here including list resize. Consider integrated linked list with transfer items or stack array instead. -- To view, visit http://gerrit.cloudera.org:8080/24176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf7ab105a851ef4d583efc2d1b33d57607810df0 Gerrit-Change-Number: 24176 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 09 Apr 2026 15:02:35 +0000 Gerrit-HasComments: Yes
