Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24176 )
Change subject: WIP [rpc] in-bulk memory recycling for Connection::ProcessOutboundTransfers() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24176/2/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: http://gerrit.cloudera.org:8080/#/c/24176/2/src/kudu/rpc/connection.cc@699 PS2, Line 699: outbound_transfers_.pop_front(); This looks weird. outbound_transfers_ stores values (of a class extending boost::intrusive::list_base_hook). Wouldn't pop_front() result in calling its destructor? How can we safely call delete (or make a copy) after that? -- To view, visit http://gerrit.cloudera.org:8080/24176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf7ab105a851ef4d583efc2d1b33d57607810df0 Gerrit-Change-Number: 24176 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 09 Apr 2026 17:55:49 +0000 Gerrit-HasComments: Yes
