Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24319 )
Change subject: KUDU-3730 Add observability counters to the auto-rebalancer ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24319/2/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/24319/2/src/kudu/master/auto_rebalancer-test.cc@1433 PS2, Line 1433: nit:remove extra line http://gerrit.cloudera.org:8080/#/c/24319/2/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/24319/2/src/kudu/tools/rebalancer_tool.cc@1212 PS2, Line 1212: std::ignore = rebalancer_->FindReplicas(move, raw_info, &tablet_ids); How about using the return value here and putting that below rather than a literal false. The comment here is OK, to account for that we could maybe add a check here? WDYT? -- To view, visit http://gerrit.cloudera.org:8080/24319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34ab527033ed71b1b591d86387f7f3af2dd4f6a3 Gerrit-Change-Number: 24319 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 12:53:25 +0000 Gerrit-HasComments: Yes
