Gabriella Lotz has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24319 )

Change subject: KUDU-3730 Add observability counters to the auto-rebalancer
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24319/2/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/24319/2/src/kudu/master/auto_rebalancer-test.cc@1433
PS2, Line 1433:
> nit:remove extra line
Done


http://gerrit.cloudera.org:8080/#/c/24319/2/src/kudu/tools/rebalancer_tool.cc
File src/kudu/tools/rebalancer_tool.cc:

http://gerrit.cloudera.org:8080/#/c/24319/2/src/kudu/tools/rebalancer_tool.cc@1212
PS2, Line 1212:       LOG(WARNING) << Substitute(
> How about using the return value here and putting that below rather than a
I have added a warning if the return value is true.



--
To view, visit http://gerrit.cloudera.org:8080/24319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34ab527033ed71b1b591d86387f7f3af2dd4f6a3
Gerrit-Change-Number: 24319
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Thu, 28 May 2026 15:13:08 +0000
Gerrit-HasComments: Yes

Reply via email to