Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24319 )
Change subject: KUDU-3730 Add observability counters to the auto-rebalancer ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/24319/3/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24319/3/src/kudu/master/auto_rebalancer.cc@379 PS3, Line 379: RETURN_NOT_OK(FindMovesToReimposePlacementPolicy( q: Moves produced by the policy-fixer path (FindMovesToReimposePlacementPolicy) construct Rebalancer::ReplicaMove directly, so is_leader_move keeps its default of false and these are always counted as follower moves in ExecuteMoves(). If a policy-fix move replaces a leader replica, follower_moves_scheduled will be incremented even though the description says "the source replica was a non-leader follower." Is that acceptable, or should policy-fixer moves be classified (or counted in a separate bucket) so the leader/follower split stays accurate? -- To view, visit http://gerrit.cloudera.org:8080/24319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34ab527033ed71b1b591d86387f7f3af2dd4f6a3 Gerrit-Change-Number: 24319 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 13:28:23 +0000 Gerrit-HasComments: Yes
