Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24319 )
Change subject: KUDU-3730 Add observability counters to the auto-rebalancer ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24319/3/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24319/3/src/kudu/master/auto_rebalancer.cc@379 PS3, Line 379: if (!rep_moves.empty()) { > q: Moves produced by the policy-fixer path (FindMovesToReimposePlacementPol Good catch. Turns out the count is already right, the fixer prefers a non-leader and only picks the leader if it's the only replica in the over-crowded location, which can't happen for a real violation (that location always has ?2 replicas, and RF=2 bails out earlier). But it was right by accident, since the default just happened to match. I've set is_leader_move explicitly based on the chosen replica's role so we're not leaning on that. No behavior change. I'd leave out a separate policy-fixer counter though, these two are about leader vs follower disruption, not where the move came from. -- To view, visit http://gerrit.cloudera.org:8080/24319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34ab527033ed71b1b591d86387f7f3af2dd4f6a3 Gerrit-Change-Number: 24319 Gerrit-PatchSet: 4 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 17:20:04 +0000 Gerrit-HasComments: Yes
