Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24901 )
Change subject: KUDU-2874 Add option to allow huge cells. ...................................................................... Patch Set 4: > Patch Set 3: > > (3 comments) > > Couple observations from my end. > Test coverage gaps: the new restart test and the un-DISABLED reproducer are > good, but I think it would be good to see coverage for: > - Upper-bound enforcement: a cell larger than max_huge_cell_size_bytes is > rejected even when allow_huge is set (and that a non-huge table still rejects > at max_cell_size_bytes). This is the core new limit and is currently untested. > - Config round-trip / parse: ParseAllowHugeConfig — valid "auto_batch_size", > invalid value returns InvalidArgument, and ExtraConfigPBFromPBMap <-> > ExtraConfigPBToPBMap round-trips the kudu.table.allow_huge key. The > disable_compaction pattern in alter_table-test.cc:2732 is a good template. > (These are small, cheap unit tests) Added the 2 new requested test. -- To view, visit http://gerrit.cloudera.org:8080/24901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a736933cbe58b7a174fac629b0e8b3d3bd72c18 Gerrit-Change-Number: 24901 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 28 Sep 2026 12:44:46 +0000 Gerrit-HasComments: No
