Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24901 )
Change subject: KUDU-2874 Add option to allow huge cells. ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/24901/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/24901/3/src/kudu/tablet/tablet.cc@1475 PS3, Line 1475: default: > The switch only accounts for INSERT/INSERT_IGNORE/UPSERT/UPSERT_IGNORE (UPD Update added in: https://gerrit.cloudera.org/c/24966 http://gerrit.cloudera.org:8080/#/c/24901/3/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/24901/3/src/kudu/tablet/tablet_metadata.cc@1047 PS3, Line 1047: } > Nothing in this patch prevents allow_huge from being reset to NOT_ALLOWED ( This won't be the only thing allowing the user to shoot itself in the foot. It is a table level setting, I will remove the obsolete todo. I don't know if it can be made "safe". User should understand what the flag does, and not carelessly remove it from an already huge table. http://gerrit.cloudera.org:8080/#/c/24901/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/24901/3/src/kudu/tserver/tablet_service.cc@3242 PS3, Line 3242: if (tablet_metadata->allows_huge_cells()) { > allows_huge_cells() takes data_lock_ (a simple_spinlock, see tablet_metadat I switched to a cached atomic. -- To view, visit http://gerrit.cloudera.org:8080/24901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a736933cbe58b7a174fac629b0e8b3d3bd72c18 Gerrit-Change-Number: 24901 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 28 Sep 2026 13:49:30 +0000 Gerrit-HasComments: Yes
