Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24901 )
Change subject: KUDU-2874 Add option to allow huge cells. ...................................................................... Patch Set 4: (4 comments) Overall logic seems ok to me. I still need to go through the test coverage. A few questions/comments. http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/common/generic_iterators.cc@92 PS4, Line 92: 8 > Is this empirical-based setting? Where does the default setting come from? +1 Instead of a constant multiplier, would it make sense to have this flag based and auto-tuned on cell size? In other words, irrespective of different cell sized tables, the memory per iterator stays flat. http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/tablet.cc@3492 PS4, Line 3492: merge_row_buffer_size With 'FLAGS_merge_scan_multiplier' as default constant and auto-tuned 'batch_size_override' for near 1MiB cells, would total size requirements increase with more number of rowsets in picture? http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/tablet.cc@3493 PS4, Line 3493: std::min<int64_t>(buffer_size, std::numeric_limits<int>::max())); Should there be a tighter cap with semantic memory protection instead of looking to prevent integer overflow? http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/tablet_metadata.cc@1073 PS4, Line 1073: MaybeLowerBatchSizeOverride Does batch_size_override_ remain on the same low value even if there are only small sized rows? If yes, do you think that can impact scans where only small sized rows are retrieved? -- To view, visit http://gerrit.cloudera.org:8080/24901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a736933cbe58b7a174fac629b0e8b3d3bd72c18 Gerrit-Change-Number: 24901 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2026 13:04:29 +0000 Gerrit-HasComments: Yes
