Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24901 )
Change subject: KUDU-2874 Add option to allow huge cells. ...................................................................... Patch Set 4: (6 comments) Thanks a lot for putting this together! I've started looking at this changelist; planning to continue tomorrow morning. I'm posting a few high-level questions at this time; more feedback is expected soon. http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/common/common.proto@540 PS4, Line 540: AllowHuge As a naming convention for protobuf in Kudu, PB suffix is usually omitted, so something like AllowHugeCells seems to be a more descriptive and aligns with the naming conventions. Also, this particular enum is more about scan batch sizing, not huge cells per se. Aren't these two separate/orthogonal? Once adaptive batch sizing is introduced, it might be employed for any table where the caller wants to have more control over the memory allocated by server-side scanner objects, right? http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/common/generic_iterators.cc@92 PS4, Line 92: 8 Is this empirical-based setting? Where does the default setting come from? http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/metadata.proto File src/kudu/tablet/metadata.proto: http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/metadata.proto@195 PS4, Line 195: in rows nit: in number of rows? http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/tablet.cc@175 PS4, Line 175: max_scan_batch_size_approx We tend to name flags to reflect the unit (unless it's a pure count). So, something like max_scan_batch_approx_size_bytes and similar looks a bit more appropriate here. http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/tablet.cc@178 PS4, Line 178: smaller row batches ... less number of rows in a batch ... http://gerrit.cloudera.org:8080/#/c/24901/4/src/kudu/tablet/tablet.cc@1468 PS4, Line 1468: TODO(zmartonka): add updates too. Do you plan to address this in a separate changelist of this is pending TODO for the next PS in this review? -- To view, visit http://gerrit.cloudera.org:8080/24901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a736933cbe58b7a174fac629b0e8b3d3bd72c18 Gerrit-Change-Number: 24901 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2026 03:28:41 +0000 Gerrit-HasComments: Yes
