Todd Lipcon has posted comments on this change. Change subject: KUDU-1386 NaN float and double values are not handled correctly ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3142/1/src/kudu/common/types.h File src/kudu/common/types.h: Line 53: NONCOMPARABLE = 12 > I disagree. Postgres is clearly doing the wrong thing here because of a te Even outside btree-style indexing, I think it's still very useful to be able to rely on total order for things liek storing per-block min/max values, etc. With NaN being non-comparable, that means you have to always scan everything, as far as I can think (or keep an extra boolean about whether there are any NaNs). Although it's 'weird' that Postgres does this, the reality is that postgres is a de facto standard in MPP database land (most are derivatives thereof) -- To view, visit http://gerrit.cloudera.org:8080/3142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I194dcddeb8eabcc67699661b9cc9362a99f2f4ae Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
