David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3667/1//COMMIT_MSG Commit Message: Line 7: KUDU-1492: Show column encodings/compression on table page in master leave a blank line between the commit title and the description. Line 8: Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 Usually our commit messages are a little more informative (see other commits) but this is simple enough that I understand if you want to leave it like that. Also max 80 cols on commit messages. Not super strict on that but it would be nice. http://gerrit.cloudera.org:8080/#/c/3667/1/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: PS1, Line 40: spaces instead of tabs. check out google style guide. PS1, Line 55: same -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
