Adar Dembo has posted comments on this change. Change subject: Doxygen for C++ client API ......................................................................
Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h File src/kudu/client/client.h: > 1. It's a purely stylistic change, it's not related to doxygen requirement 1. OK, then I think reverting back to one space makes sense. 2. Thanks, that makes sense. 3. Cool. Crap, I just realized I didn't publish this after I looked at PS10. Now I understand why you hadn't changed anything based on #1 until we talked on HipChat. My mistake. Line 432: > I don't understand what "Required" and "Optional" tags are in this context. I'm referring to how, in some of the old comments here, there were one-word sentences like "Required." or "Optional." that help the user understand which builder methods they must call and which they can omit. http://gerrit.cloudera.org:8080/#/c/3619/11/src/kudu/client/client.h File src/kudu/client/client.h: Line 767: /// the opration is complete. Otherwise, every operation returns immediately. Nit: operation Line 1079: /// @copydoc KuduSession::Flush() Will this also include the "Flush any pending writes" sentence from Flush()? If so, that would be kind of weird. Line 1332: /// @return Result status of the operation (beging scanning). Nit: begin scanning -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org> Gerrit-HasComments: Yes
