> On April 13, 2015, 6:30 p.m., haosdent huang wrote:
> > docs/effective-code-reviewing.md, line 14
> > <https://reviews.apache.org/r/32998/diff/1/?file=921214#file921214line14>
> >
> >     Should we add a requirement that "pass unit tests before post reviews" 
> > here?

Thanks! Haven't seen this one to be a common mistake so I left it out, but 
let's keep an eye open for extra things to add here!


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32998/#review79912
-----------------------------------------------------------


On April 9, 2015, 12:30 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32998/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 12:30 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-2581
>     https://issues.apache.org/jira/browse/MESOS-2581
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> "Committer's Guide" was too generic. This names the documents after "what" 
> the reader is looking for: doing effective reviews, and how to commit changes 
> (for committers only).
> 
> 
> Diffs
> -----
> 
>   docs/committers-guide.md c016ee9cb3290d7788ed258904547b59bbea4f11 
>   docs/committing.md PRE-CREATION 
>   docs/effective-code-reviewing.md PRE-CREATION 
>   docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea 
> 
> Diff: https://reviews.apache.org/r/32998/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to