> On April 20, 2015, 7:28 p.m., Niklas Nielsen wrote: > > docs/effective-code-reviewing.md, line 19 > > <https://reviews.apache.org/r/32998/diff/1/?file=921214#file921214line19> > > > > s/, this is not meant to be a sparring match!/./
Hm.. this was copy/pasted from benh's original committer's guide. Can you tell me more about why you think it should be omitted? FWIW, I don't see it happening lately, but it has come up in the past which is why I think it was added :) > On April 20, 2015, 7:28 p.m., Niklas Nielsen wrote: > > docs/effective-code-reviewing.md, line 21 > > <https://reviews.apache.org/r/32998/diff/1/?file=921214#file921214line21> > > > > s/**//g `**` is bold, you want to remove all the emphasis in this document..? > On April 20, 2015, 7:28 p.m., Niklas Nielsen wrote: > > docs/committing.md, line 13 > > <https://reviews.apache.org/r/32998/diff/1/?file=921213#file921213line13> > > > > Very long line. Do we have a style guide for markdown somewhere? I > > would think that 80 cols would work :) Would love to have a markdown `fmt` / linter that we can run! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32998/#review80786 ----------------------------------------------------------- On April 9, 2015, 12:30 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32998/ > ----------------------------------------------------------- > > (Updated April 9, 2015, 12:30 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, > and Vinod Kone. > > > Bugs: MESOS-2581 > https://issues.apache.org/jira/browse/MESOS-2581 > > > Repository: mesos > > > Description > ------- > > "Committer's Guide" was too generic. This names the documents after "what" > the reader is looking for: doing effective reviews, and how to commit changes > (for committers only). > > > Diffs > ----- > > docs/committers-guide.md c016ee9cb3290d7788ed258904547b59bbea4f11 > docs/committing.md PRE-CREATION > docs/effective-code-reviewing.md PRE-CREATION > docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea > > Diff: https://reviews.apache.org/r/32998/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Ben Mahler > >
