> On May 20, 2015, 9:18 a.m., Joerg Schad wrote: > > 3rdparty/libprocess/include/process/process.hpp, line 36 > > <https://reviews.apache.org/r/33295/diff/3-4/?file=946421#file946421line36> > > > > Do we use this doxygen style anywhere else? Could not find any > > occurence in c++ code.
`grep --include="*.[ch]pp" --include="*.[ch]" --exclude="*_tests.cpp" --exclude-dir="build" -RFIn '@param' .` shows multiple instances of this doxygen style. > On May 20, 2015, 9:18 a.m., Joerg Schad wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, line 1912 > > <https://reviews.apache.org/r/33295/diff/4/?file=947286#file947286line1912> > > > > s/Sets/Tests? It is "sets" but I did improve the comment, so no one has this discussion again. > On May 20, 2015, 9:18 a.m., Joerg Schad wrote: > > 3rdparty/libprocess/src/process.cpp, line 696 > > <https://reviews.apache.org/r/33295/diff/4/?file=947285#file947285line696> > > > > does our styleguide allow std::move? It is a logical implication. If rvalues are allowed, they cannot be used without move. Though we may need to add it to our styleguide if we want to be picky. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review84473 ----------------------------------------------------------- On May 20, 2015, 9:46 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33295/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 9:46 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff. > > > Bugs: MESOS-2620 > https://issues.apache.org/jira/browse/MESOS-2620 > > > Repository: mesos > > > Description > ------- > > Introduces the interface `FirewallRule` which will be matched against > incoming connections in order to allow them to be served or being blocked. > For details, check the [design > doc](https://docs.google.com/document/d/1JSJTJMJ6ZXLkCSmvOIabTLrjtqqr0E-u99Rx2BHR1hs/edit). > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > 8aab0593f296c7aae71289f9bd6cf3eb3578a721 > 3rdparty/libprocess/include/process/firewall.hpp PRE-CREATION > 3rdparty/libprocess/include/process/process.hpp > 392c74df3e8a122aecd3633dffdeec4bcbd1f097 > 3rdparty/libprocess/src/process.cpp > e3de3cd6b536aaaf59784360aed546512dd04dc9 > 3rdparty/libprocess/src/tests/process_tests.cpp > 67e582cc250a9767a389e2bd0cc68985477f3ffb > > Diff: https://reviews.apache.org/r/33295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
