-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86283
-----------------------------------------------------------

Ship it!



src/tests/mesos.hpp
<https://reviews.apache.org/r/34816/#comment138252>

    Any reason for WillByDefault(..)?
    
    EXPECT_CALL(...)
      .WillRepeatedly(Return(...));
    
    Should work, right?



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34816/#comment138253>

    This is implicit and you can remove it :)
    
    Here and below


- Niklas Nielsen


On June 2, 2015, 1:36 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34816/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 1:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> TestResourceEstimator changed to be a  MockResourceEstimator with mocked 
> methods - to inject resources and test plumbing between RE and Slave.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b 
>   src/tests/oversubscription_tests.cpp 
> ea5857cb579aa904fd05530684bdde51a0b3f27f 
> 
> Diff: https://reviews.apache.org/r/34816/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to