-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86235
-----------------------------------------------------------


Looks good! Final questions, tiny nits and let's get this in!


src/tests/mesos.hpp
<https://reviews.apache.org/r/34816/#comment138156>

    How will this work, when we can't access the mocked resource estimator from 
the test body?



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34816/#comment138150>

    One newline



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34816/#comment138157>

    Shouldn't we have 'using process::Queue;' somewhere above?



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34816/#comment138159>

    Mind moving the comment above line 92 (before the chain?) Here and below



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34816/#comment138154>

    fits on one line



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34816/#comment138151>

    Why did you change the cpu counts?


- Niklas Nielsen


On June 1, 2015, 5:38 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34816/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> TestResourceEstimator changed to be a  MockResourceEstimator with mocked 
> methods - to inject resources and test plumbing between RE and Slave.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b 
>   src/tests/oversubscription_tests.cpp 
> ea5857cb579aa904fd05530684bdde51a0b3f27f 
> 
> Diff: https://reviews.apache.org/r/34816/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to