> On June 2, 2015, 4:24 p.m., Niklas Nielsen wrote:
> > src/tests/mesos.hpp, line 797
> > <https://reviews.apache.org/r/34816/diff/7/?file=976043#file976043line797>
> >
> >     How will this work, when we can't access the mocked resource estimator 
> > from the test body?

You were right - default MockResourceEstimator behaviour needed. Fixed that.


> On June 2, 2015, 4:24 p.m., Niklas Nielsen wrote:
> > src/tests/oversubscription_tests.cpp, line 93
> > <https://reviews.apache.org/r/34816/diff/7/?file=976044#file976044line93>
> >
> >     Shouldn't we have 'using process::Queue;' somewhere above?

Actually - we have.


> On June 2, 2015, 4:24 p.m., Niklas Nielsen wrote:
> > src/tests/oversubscription_tests.cpp, line 267
> > <https://reviews.apache.org/r/34816/diff/7/?file=976044#file976044line267>
> >
> >     Why did you change the cpu counts?

I thought - it would more intersting test case - to shrink slack resources. I 
reverted that (:


- Bartek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86235
-----------------------------------------------------------


On June 2, 2015, 7:37 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34816/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 7:37 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> TestResourceEstimator changed to be a  MockResourceEstimator with mocked 
> methods - to inject resources and test plumbing between RE and Slave.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b 
>   src/tests/oversubscription_tests.cpp 
> ea5857cb579aa904fd05530684bdde51a0b3f27f 
> 
> Diff: https://reviews.apache.org/r/34816/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to