-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86271
-----------------------------------------------------------



src/tests/mesos.hpp
<https://reviews.apache.org/r/34816/#comment138227>

    You want to use both ON_CALL and EXPECT_CALL. See TestAllocator in 
tests/mesos.hpp for the rationale.



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34816/#comment138228>

    You don't need to explicitly do this you setup both ON_CALL and EXPECT_CALL 
above.



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34816/#comment138230>

    Why is this *action* pulled up? What if the schedule receives an offer 
before #194 gets executed?
    
    As a general rule, an action should come after an expectation is set and 
before the expectation is evaluated.


- Vinod Kone


On June 2, 2015, 7:37 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34816/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 7:37 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> TestResourceEstimator changed to be a  MockResourceEstimator with mocked 
> methods - to inject resources and test plumbing between RE and Slave.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b 
>   src/tests/oversubscription_tests.cpp 
> ea5857cb579aa904fd05530684bdde51a0b3f27f 
> 
> Diff: https://reviews.apache.org/r/34816/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to