-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/
-----------------------------------------------------------
(Updated Aug. 6, 2015, 4:08 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Added a continuation function for failoverFramework(...) that is common to both
http and pid frameworks. Made the readerClosed callback as part of addFramework
similar to link(...)
Bugs: MESOS-2294
https://issues.apache.org/jira/browse/MESOS-2294
Repository: mesos
Description
-------
Split review out of r36318. This change adds the functionality of making a http
call for subscribe and the master responding with a subscribed event on the
persistent stream.
Also added functionality for framework failover equivalent of re-register. It
should now be possible to merge the subscribed(...) introduced in this review
and the re-factor that happened in MESOS-3182.
- Made a new function for exited()/failoverFramework for http frameworks that
invoke into the common continuation function for pid/http frameworks thereafter.
- The re-register functionality equivalent goes in _subscribe(...)
Diffs (updated)
-----
src/common/http.hpp 9e4290f9e1f72730f63466d498a953cc5031a92b
src/common/http.cpp a74c51d9392d0b0a67d51a0143eb314cfca11245
src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3
src/master/master.hpp e44174976aa64176916827bec4c911333c9a91db
src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43
Diff: https://reviews.apache.org/r/36720/diff/
Testing
-------
make check + adding tests in a different patch.
Thanks,
Anand Mazumdar
