> On Aug. 7, 2015, 7:14 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 4950 > > <https://reviews.apache.org/r/36720/diff/10/?file=1034017#file1034017line4950> > > > > Much like when we remove a pid-based framework, we need to wipe the > > authentication related data here.
Good catch ! Since currently http framework workflow only works when the authentication workflow is not active, I never noticed this, my bad. > On Aug. 7, 2015, 7:14 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 4983 > > <https://reviews.apache.org/r/36720/diff/10/?file=1034017#file1034017line4983> > > > > This check will crash when an http scheduler is downgrading to a pid > > framework. I was under the impression that we would be tackling downgrades in a later patch and thought that it would be good to crash for the time being then perform "incorrect" behavior. I would add tests around the downgrade scenarios too similar to the upgrade ones I added in 37082. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94496 ----------------------------------------------------------- On Aug. 7, 2015, 2:27 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36720/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 2:27 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-2294 > https://issues.apache.org/jira/browse/MESOS-2294 > > > Repository: mesos > > > Description > ------- > > Split review out of r36318. This change adds the functionality of making a > http call for subscribe and the master responding with a subscribed event on > the persistent stream. > > Also added functionality for framework failover equivalent of re-register. It > should now be possible to merge the subscribed(...) introduced in this review > and the re-factor that happened in MESOS-3182. > > - Made a new function for exited()/failoverFramework for http frameworks that > invoke into the common continuation function for pid/http frameworks > thereafter. > - The re-register functionality equivalent goes in _subscribe(...) > > > Diffs > ----- > > src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 > src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 > src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702 > > Diff: https://reviews.apache.org/r/36720/diff/ > > > Testing > ------- > > make check + adding tests in a different patch. > > > Thanks, > > Anand Mazumdar > >
