----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94428 -----------------------------------------------------------
Thanks, I'll get the HttpConnection change committed, left some notes about things I updated. Also opened some issues in the subscribe path that I noticed while doing this. src/common/http.hpp (line 50) <https://reviews.apache.org/r/36720/#comment149022> Hm.. let's at least say that it's based on the content type. src/common/http.cpp (line 49) <https://reviews.apache.org/r/36720/#comment149021> No need for std:: here src/common/http.cpp (lines 61 - 63) <https://reviews.apache.org/r/36720/#comment149020> How about we just put UNREACHABLE at the bottom outside the switch? That way, we don't lose the switch warning for missing enum cases, right? src/master/master.hpp (lines 1542 - 1544) <https://reviews.apache.org/r/36720/#comment149023> Let's have the master decide when to set up this callback. On that note, how about we add a `closed()` on the HttpConnection as well? src/master/master.cpp (line 2216) <https://reviews.apache.org/r/36720/#comment149024> This change looks like a regression, now we're sending to '`framework->pid`' instead of '`from`'? src/master/master.cpp <https://reviews.apache.org/r/36720/#comment149027> Don't we still want this since we call pid.get()? - Ben Mahler On Aug. 6, 2015, 4:25 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36720/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 4:25 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-2294 > https://issues.apache.org/jira/browse/MESOS-2294 > > > Repository: mesos > > > Description > ------- > > Split review out of r36318. This change adds the functionality of making a > http call for subscribe and the master responding with a subscribed event on > the persistent stream. > > Also added functionality for framework failover equivalent of re-register. It > should now be possible to merge the subscribed(...) introduced in this review > and the re-factor that happened in MESOS-3182. > > - Made a new function for exited()/failoverFramework for http frameworks that > invoke into the common continuation function for pid/http frameworks > thereafter. > - The re-register functionality equivalent goes in _subscribe(...) > > > Diffs > ----- > > src/common/http.hpp 9e4290f9e1f72730f63466d498a953cc5031a92b > src/common/http.cpp a74c51d9392d0b0a67d51a0143eb314cfca11245 > src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 > src/master/master.hpp e44174976aa64176916827bec4c911333c9a91db > src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43 > > Diff: https://reviews.apache.org/r/36720/diff/ > > > Testing > ------- > > make check + adding tests in a different patch. > > > Thanks, > > Anand Mazumdar > >
