> On Aug. 6, 2015, 4:10 p.m., Vinod Kone wrote:
> > src/common/http.cpp, line 60
> > <https://reviews.apache.org/r/36720/diff/8/?file=1033227#file1033227line60>
> >
> >     need a return here to aviod compiler warning.

I am putting in a fix for that. This looks to be as a GCC bug. With 
-Werror=uninitialized, -Wswitch turned on in our code. It shouldn't ever 
complain. Clang rightfully figures this out but GCC does not. Would go ahead 
and put in a default: UNREACHABLE() workaround here for now.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/#review94413
-----------------------------------------------------------


On Aug. 6, 2015, 4:08 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36720/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 4:08 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-2294
>     https://issues.apache.org/jira/browse/MESOS-2294
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Split review out of r36318. This change adds the functionality of making a 
> http call for subscribe and the master responding with a subscribed event on 
> the persistent stream.
> 
> Also added functionality for framework failover equivalent of re-register. It 
> should now be possible to merge the subscribed(...) introduced in this review 
> and the re-factor that happened in MESOS-3182.
> 
> - Made a new function for exited()/failoverFramework for http frameworks that 
> invoke into the common continuation function for pid/http frameworks 
> thereafter.
> - The re-register functionality equivalent goes in _subscribe(...)
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 9e4290f9e1f72730f63466d498a953cc5031a92b 
>   src/common/http.cpp a74c51d9392d0b0a67d51a0143eb314cfca11245 
>   src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 
>   src/master/master.hpp e44174976aa64176916827bec4c911333c9a91db 
>   src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43 
> 
> Diff: https://reviews.apache.org/r/36720/diff/
> 
> 
> Testing
> -------
> 
> make check + adding tests in a different patch.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to