> On Aug. 24, 2015, 11:04 p.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 111
> > <https://reviews.apache.org/r/36571/diff/14/?file=1048532#file1048532line111>
> >
> >     Can you please show a case why end user want to hold more agents on a 
> > single machine? This may cause resource overcommit for the single machine.

In this case, it doesn't matter *why* the user puts 2+ agents on a single 
machine.  It matters that the user *can* put 2+ agents on a single machine.


> On Aug. 24, 2015, 11:04 p.m., Guangya Liu wrote:
> > include/mesos/maintenance/maintenance.proto, line 19
> > <https://reviews.apache.org/r/36571/diff/14/?file=1048531#file1048531line19>
> >
> >     I think that you will handle v1 api in other patches?

That is correct.  Specifically, for the maintenance protobufs, we will add it 
to the V1 API when it is necessary to do so.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96301
-----------------------------------------------------------


On Aug. 24, 2015, 11:33 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 11:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
>     https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * MachineInfo - Describes a single box that holds one or more agents.
> * MachineInfos - A list of boxes.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> * maintenance::Mode - An enum for the three states of maintenance: Normal, 
> Draining, Deactivated.
> * Registry::MaintenanceStatus - Holds the maintenance mode of a machine.
> 
> 
> Diffs
> -----
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to